Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraintlayout-compose for Kotlin Multiplatform Compatibility #465

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Remove constraintlayout-compose for Kotlin Multiplatform Compatibility #465

merged 1 commit into from
Aug 14, 2023

Conversation

fornewid
Copy link
Contributor

Issue

Overview (Required)

  • Remove dependencies from all feature modules. 👋
  • Use additional Spacer to align the layout without ConstraintLayout.

Links

  • None

Screenshot

Before After

@takahirom
Copy link
Member

Oh, I'm going to remove the dependency diff action👀

@takahirom
Copy link
Member

You are the first contributor after being public!!🏆

@fornewid
Copy link
Contributor Author

Oh, I'm going to remove the dependency diff action👀

Yes, dependency_diff action is not working properly for forked repository. 🥲

You are the first contributor after being public!!🏆

Oh, I'm glad!

@github-actions
Copy link

Test Results

27 tests   27 ✔️  3m 21s ⏱️
  7 suites    0 💤
  7 files      0

Results for commit 7acc7f8.

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your fast contribution!

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2023 14:13 Inactive
@takahirom takahirom merged commit 498e4a6 into DroidKaigi:main Aug 14, 2023
5 of 6 checks passed
@fornewid fornewid deleted the goodbye-constraintlayout branch August 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove constraintlayout-compose for Kotlin Multiplatform Compatibility
2 participants