Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed, #276 BookmarkFilters uses Theme Color #469

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fixed, #276 BookmarkFilters uses Theme Color #469

merged 2 commits into from
Aug 14, 2023

Conversation

Pluu
Copy link
Contributor

@Pluu Pluu commented Aug 14, 2023

Issue

Overview (Required)

  • Use the value of MaterialTheme.colorScheme instead of the fixed color.
  • Mapping
    • containerColor : MaterialTheme.colorScheme.primary
    • labelColor : MaterialTheme.colorScheme.onPrimary
    • border color : MaterialTheme.colorScheme.outline

Links

  • None

Screenshot

Before After

@github-actions
Copy link

Hi @Pluu! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

Test Results

27 tests   27 ✔️  2m 42s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 8f00b66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Snapshot diff report

File name Image
KaigiAppTest.checkNa
vigateToBookmarkShot
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_D
efaultGroup_Bookmark
FiltersPreview_0_nul
l_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2023 14:34 Inactive
takahirom
takahirom approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This was blocking our dark theme applying! 🌚

@takahirom takahirom merged commit b6e7e54 into DroidKaigi:main Aug 14, 2023
5 checks passed
@Pluu Pluu mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update BookmarkFilters Colors to Use Theme Colors
2 participants
@Pluu @takahirom