Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/#271] Create UiState for BookmarkFilters to Encapsulate Business Logic #471

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[feature/#271] Create UiState for BookmarkFilters to Encapsulate Business Logic #471

merged 1 commit into from
Aug 14, 2023

Conversation

l2hyunwoo
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited by takahirom
Loading

Snapshot diff report

File name Image
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_D
efaultGroup_Bookmark
FiltersPreview_0_nul
l_compare.png

@github-actions
Copy link

Test Results

27 tests   27 ✔️  3m 50s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 7a84789.

@takahirom
Copy link
Member

The image is this 👀

https://github.com/DroidKaigi/conference-app-2023/blob/companion_feature/%23271/screenshot-diff/app-android/build/outputs/roborazzi/io.github.droidkaigi.confsched2023.sessions.component_null_DefaultGroup_BookmarkFiltersPreview_0_null_compare.png

takahirom
takahirom approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution!

@takahirom takahirom merged commit d0c67b9 into DroidKaigi:main Aug 14, 2023
5 checks passed
@l2hyunwoo l2hyunwoo deleted the feature/#271 branch August 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create UiState for BookmarkFilters to Encapsulate Business Logic
2 participants
@l2hyunwoo @takahirom