Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "R" to reference icons #476

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Use "R" to reference icons #476

merged 1 commit into from
Aug 14, 2023

Conversation

shofucchi
Copy link
Contributor

Issue

Overview (Required)

  • Use "R" to reference icons.

Links

  • None

Screenshot

Before After

@github-actions
Copy link

Snapshot diff report

File name Image
TimetableScreenTest.
checkGridShot_compar
e.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkGridScrollShot_
compare.png
TimetableScreenTest.
checkLaunchServerErr
orShot_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_D
efaultGroup_Bookmark
FiltersPreview_0_nul
l_compare.png

@github-actions
Copy link

Test Results

27 tests   27 ✔️  2m 29s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 47fa81d.

takahirom
takahirom approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the consistent code!

@takahirom takahirom merged commit 8ba2d9b into DroidKaigi:main Aug 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use R.drawable.xxx instead of drawable.xxx.
2 participants
@shofucchi @takahirom