Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/change_empty_image]: Change Empty Image #488

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[feature/change_empty_image]: Change Empty Image #488

merged 1 commit into from
Aug 14, 2023

Conversation

kez-lab
Copy link
Contributor

@kez-lab kez-lab commented Aug 14, 2023 •
edited
Loading

Issue

Overview (Required)

  • Change Empty View from Icon to Image
  • The img_empty SVG exported from figma was not applied, so it was added as PNG.

Screenshot

Before After

@github-actions
Copy link

Snapshot diff report

File name Image
KaigiAppTest.checkNa
vigateToSearchShot_c
ompare.png

@github-actions
Copy link

Test Results

27 tests   27 ✔️  3m 2s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 959b631.

takahirom
takahirom approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@takahirom takahirom merged commit 9a1b1d7 into DroidKaigi:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the no result icon on timetable search screen
2 participants
@kez-lab @takahirom