Proper layout of AssistChip in the archive portion of the timetable detail screen. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ドキュメント" to "資料
- Change Filled icon to Outline - Implementation of TimeTableIconButton using slot api concept
|
Snapshot diff report
|
|
Hi @toastmeister1! Codes seem to be unformatted. To resolve this issue, please run |
takahirom
reviewed
Aug 14, 2023
Comment on lines
+220
to
+225
| private fun ArchiveSectionIconButton( | ||
| icon: @Composable () -> Unit, | ||
| label: @Composable () -> Unit, | ||
| onClick: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| iconSpacing: Dp = 8.dp, |
There was a problem hiding this comment.
Amazing! You use the Slot API pattern appropriately! Are you a Compose professional, right?
There was a problem hiding this comment.
I've always been interested in Compose, so I gave it a try.
I'm glad you liked it.
I hope your conference will be a success :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Make the following modifications
Links
Screenshot