Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed, BookmarkFilters chip color #493

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Pluu
Copy link
Contributor

@Pluu Pluu commented Aug 14, 2023

Issue

Overview (Required)

  • According to the M3 Color Rule, a chip should have a secondary container applied to it.
  • Use secondary container Color
  • The Light Theme colors you see in Figma are different from the actual Secondary colors, but that's a different issue, so we're only focusing on the color mapping.

Links

Screenshot

Before After

Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating them! LGTM.

The Light Theme colors you see in Figma are different from the actual Secondary colors, but that's a different issue, so we're only focusing on the color mapping.

Absolutely. It is related to the diff in the definition between design system and Figma. So let us make another issue about that 🙏

@github-actions
Copy link

Test Results

27 tests   27 ✔️  2m 46s ⏱️
  7 suites    0 💤
  7 files      0

Results for commit b1c2c72.

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@takahirom takahirom merged commit b9da59e into DroidKaigi:main Aug 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BookmarkFilters Chip has the wrong color applied to it.
3 participants