Address FIXME in Animation Calculation in BookmarkTopArea.kt

[tfandkusu]

Issue

• close Address FIXME in Animation Calculation in BookmarkTopArea.kt #273

Overview (Required)

Problem

• On this issue, titlePaddingStart and titlePaddingTop in the BookmarkTopArea.kt is calculated by fraction.
• fraction is culculated by scrollState.firstVisibleItemScrollOffset and fixed pixel 520.
• If user selects large font and bookmarks item which has long title, scrollState.firstVisibleItemScrollOffset may be more than 520 pixel.
• So fraction may be more than 1.0f.
• So titlePaddingTop may be less than 0.0f.
• Modifier.padding must not be a negative value, or the app will crash.

Solution

• I use min method to limit fraction from 0.0f to 1.0f.

Links

• Previous PR Address FIXME in Animation Calculation in BookmarkTopArea.kt #482 (I misunderstood the intent of the Issue.)

Screenshot

Before(not use if expresson)	After
screencap-2023-08-14T162514.532Z.mp4	screencap-2023-08-14T160936.558Z.mp4

[takahirom]

Looks good!

[github-actions]

Test Results

27 tests   27 ✔️  3m 23s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit d16da92.

[github-actions]

Snapshot diff report

File name	Image
AboutScreenTest.chec kLaunchShot_compare. png
io.github.droidkaigi .confsched2023.about .component_null_Defa ultGroup_AboutDroidK aigiDetailPreview_1_ null_compare.png
io.github.droidkaigi .confsched2023.about .component_null_Defa ultGroup_AboutDroidK aigiDetailDarkModePr eview_1_null_compare .png
io.github.droidkaigi .confsched2023.about .component_null_Defa ultGroup_AboutDroidK aigiDetailDarkModePr eview_0_null_compare .png
KaigiAppTest.checkNa vigateToAboutShot_co mpare.png
io.github.droidkaigi .confsched2023.about .component_null_Defa ultGroup_AboutDroidK aigiDetailPreview_0_ null_compare.png