Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bookmark Icon to bookmarks Icon in TimetableTopArea #496

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update Bookmark Icon to bookmarks Icon in TimetableTopArea #496

merged 1 commit into from
Aug 14, 2023

Conversation

sanao1006
Copy link
Contributor

Issue

Overview (Required)

  • Change Icon to bookmark instead of bookmarks to clarify not bookmarking

Screenshot

Before After
image after

@github-actions
Copy link

Test Results

31 tests   31 ✔️  3m 25s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 1a0eafb.

@github-actions
Copy link

Snapshot diff report

File name Image
TimetableScreenTest.
checkGridShot_compar
e.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkGridScrollShot_
compare.png
TimetableScreenTest.
checkLaunchServerErr
orShot_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
KaigiAppTest.checkSt
artupShot_compare.pn
g

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2023 17:24 Inactive
takahirom
takahirom approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@takahirom takahirom merged commit f9ae869 into DroidKaigi:main Aug 14, 2023
5 checks passed
@sanao1006 sanao1006 deleted the change_bookmark_icons_in_timetableTopArea branch August 17, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change bookmark icons in TimetableTopArea
2 participants
@sanao1006 @takahirom