Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bookmark button accessibility #502

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Improve bookmark button accessibility #502

merged 3 commits into from
Aug 15, 2023

Conversation

Pluu
Copy link
Contributor

@Pluu Pluu commented Aug 14, 2023

Issue

Overview (Required)

  • Use IconToggleButton instead of IconButton for the Check state.
  • Added accessibility statements based on whether or not to add a bookmark.

Links

  • None

Record

Before

before.mp4

After

after.mp4

@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

Test Results

31 tests   31 ✔️  2m 42s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 0a0ccfb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Snapshot diff report

File name Image
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2023 17:37 Inactive
@takahirom
Copy link
Member

The icon color looks changed. Looks good though. Is there any opinion about this? 👀

@Pluu
Copy link
Contributor Author

Pluu commented Aug 14, 2023

@takahirom Oh!! My mistake.
I just realized this is different from the Figma design.
I'll make sure to expose it with the existing colors.

@github-actions
Copy link

Hi @Pluu! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@Pluu
Copy link
Contributor Author

Pluu commented Aug 15, 2023

@takahirom I used the same Color value for the IconToggleButton as in Figma.

Figma

Preview

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 00:42 Inactive
takahirom
takahirom approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@takahirom takahirom merged commit d7c1398 into DroidKaigi:main Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing talkback explanation for Timetable/bookmark icon button
2 participants
@Pluu @takahirom