✨ Implement Middle Section of AboutScreen #504
Conversation
| <clip-path | ||
| android:pathData="M0,0h24v24h-24z"/> | ||
| <path | ||
| android:pathData="M5,21C4.45,21 3.979,20.804 3.588,20.413C3.196,20.021 3,19.55 3,19V9C3,8.45 3.196,7.979 3.588,7.588C3.979,7.196 4.45,7 5,7H7V5C7,4.45 7.196,3.979 7.588,3.588C7.979,3.196 8.45,3 9,3H15C15.55,3 16.021,3.196 16.413,3.588C16.804,3.979 17,4.45 17,5V11H19C19.55,11 20.021,11.196 20.413,11.587C20.804,11.979 21,12.45 21,13V19C21,19.55 20.804,20.021 20.413,20.413C20.021,20.804 19.55,21 19,21H13V17H11V21H5ZM5,19H7V17H5V19ZM5,15H7V13H5V15ZM5,11H7V9H5V11ZM9,15H11V13H9V15ZM9,11H11V9H9V11ZM9,7H11V5H9V7ZM13,15H15V13H13V15ZM13,11H15V9H13V11ZM13,7H15V5H13V7ZM17,19H19V17H17V19ZM17,15H19V13H17V15Z" |
There was a problem hiding this comment.
Could you check if this icon is in Material Icon Library and use it? 👀
| } | ||
| item { | ||
| Text( | ||
| AboutContentColumn( |
There was a problem hiding this comment.
Now that we can't see the AboutContentColumn for Screenshot Tests, could you provide a scrolled screenshot test? 📸
| aboutScreenRobot { | ||
| setupAboutScreenContent() | ||
| scrollAboutScreen() | ||
| checkAboutContentColumnCapture() |
There was a problem hiding this comment.
From the screenshot, it seems to be capturing only a single item, but I was thinking that it would be good to have a screen-level screenshot that includes the behavior when scrolling through the entire screen. At the item level, a preview might probably suffice. My intention was to check the overall behavior of the entire screen, not just an individual item. 🙇
| aboutScreenRobot { | ||
| setupAboutScreenContent() | ||
| scrollAboutScreen() | ||
| checkStaffAboutContentColumnCapture() |
There was a problem hiding this comment.
Sorry for the confusion🙇 I mean like this
setupAboutScreenContent()
scrollAboutScreen()
checkScreenCapture()
scrollAboutScreen()
checkScreenCapture()
|
@takahirom |
|
Thank you for your cooperation! |
Issue
Overview (Required)
Screenshot