Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomTab Implementation for Web Navigation #506

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add CustomTab Implementation for Web Navigation #506

merged 1 commit into from
Aug 14, 2023

Conversation

fornewid
Copy link
Contributor

@fornewid fornewid commented Aug 14, 2023

Issue

Overview (Required)

How to use:

externalNavController.navigate(url = "https://twitter.com/DroidKaigi")

Links

Screenshot

Before After
ExternalNavController.mp4

@github-actions
Copy link

Test Results

31 tests   31 ✔️  3m 17s ⏱️
  7 suites    0 💤
  7 files      0

Results for commit ee0de06.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2023 19:57 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for addressing this essential feature!

@takahirom takahirom merged commit 2cafdc3 into DroidKaigi:main Aug 14, 2023
5 checks passed
@fornewid fornewid deleted the CustomTab branch August 15, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CustomTab Implementation for Web Navigation
2 participants