-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the design of the icons in the card section #508
Modify the design of the icons in the card section #508
Conversation
Hi @WonJoongLee! Codes seem to be unformatted. To resolve this issue, please run |
1.dp, | ||
), | ||
), | ||
colors = CardDefaults.cardColors(containerColor = Color(0xFFF2F4F1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to use theme color for applying a dark theme and it seems like we can apply it by adding elevation.
Surface at elevation +1 becomes Surface Container Low
https://material.io/blog/tone-based-surface-color-m3
The problem is how we can get elevation +1 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave this color as it is like surfaceColorAtElevation(1.dp,)
in this PR. In that case please create the issue for this 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and making issue!
Issue
Overview (Required)
Links
Screenshot