Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/#424] Implement Sponsor List and Design on SponsorsScreen #519

Merged
merged 12 commits into from
Aug 15, 2023
Merged

[feature/#424] Implement Sponsor List and Design on SponsorsScreen #519

merged 12 commits into from
Aug 15, 2023

Conversation

l2hyunwoo
Copy link
Contributor

Issue

Overview (Required)

  • Add SponsorList Composable in section package
  • Add SponsorItem, SponsorHeader in component package
  • Separate sponsors by plan at SponsorsUiState

Screenshot

@github-actions
Copy link

Hi @l2hyunwoo! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

Test Results

34 tests   34 ✔️  3m 2s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit af22b0c.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 04:56 Inactive
@takahirom
Copy link
Member

Maybe we should adjust the Fake's id or something? 👀

java.lang.IllegalArgumentException: Key "DroidKaigi" was already used. If you are using LazyColumn/Row please make sure you provide a unique key for each item.

@l2hyunwoo
Copy link
Contributor Author

@takahirom It caused by duplicated id from fake sponsor list's item. I think build/test will be fixed.

@github-actions
Copy link

Snapshot diff report

File name Image
SponsorsScreenTest.c
heckLaunchShot_compa
re.png
io.github.droidkaigi
.confsched2023.spons
ors.section_null_Def
aultGroup_SponsorLis
tPreview_0_null_comp
are.png
io.github.droidkaigi
.confsched2023.spons
ors.component_null_D
efaultGroup_SponsorI
temPreview_0_null_co
mpare.png
KaigiAppTest.checkNa
vigateToSponsorsShot
_compare.png
io.github.droidkaigi
.confsched2023.spons
ors.component_null_D
efaultGroup_SponsorH
eaderPreview_0_null_
compare.png

@takahirom
Copy link
Member

We have to change "#424" to "%23424" in url

Snapshot diff report

File name Image
SponsorsScreenTest.c
heckLaunchShot_compa
re.png
io.github.droidkaigi
.confsched2023.spons
ors.section_null_Def
aultGroup_SponsorLis
tPreview_0_null_comp
are.png
io.github.droidkaigi
.confsched2023.spons
ors.component_null_D
efaultGroup_SponsorI
temPreview_0_null_co
mpare.png
KaigiAppTest.checkNa
vigateToSponsorsShot
_compare.png
io.github.droidkaigi
.confsched2023.spons
ors.component_null_D
efaultGroup_SponsorH
eaderPreview_0_null_
compare.png

takahirom
takahirom reviewed Aug 15, 2023
View reviewed changes
feature/sponsors/src/main/java/io/github/droidkaigi/confsched2023/sponsors/SponsorsScreen.kt
)
}
},
scrollBehavior = scrollBehavior,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 08:43 Inactive
takahirom
takahirom approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks for implementing this so fast!

@takahirom takahirom merged commit 46e78a2 into DroidKaigi:main Aug 15, 2023
5 checks passed
@l2hyunwoo l2hyunwoo deleted the feature/#424 branch August 15, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Sponsor List and Design on SponsorsScreen
2 participants
@l2hyunwoo @takahirom