Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace bottomnav label stamps to badges #526

Merged
merged 3 commits into from
Aug 15, 2023
Merged

replace bottomnav label stamps to badges #526

merged 3 commits into from
Aug 15, 2023

Conversation

kudpig
Copy link
Contributor

@kudpig kudpig commented Aug 15, 2023 •
edited
Loading

Issue

Overview (Required)

  • Replaced the bottom navigation label. (Stamps -> Badges)

  • Changed MainStrings class string.

  • Icon image is not changed. (If you want to change it, please let me know. (If so, which image should I use?)

  • The value of MainScreenTab is also changed to Stamps -> Badges.
    However, The names of StampsScreen etc. remain the same.

Screenshot

Before After

kudpig added 2 commits August 15, 2023 19:42
@kudpig
replace:bottomnav_label
7b51a03 
Stamps->Badges with main strings class
@kudpig
replace:bottomTabs_enum_name
df52d49 
Stamps -> Badges
@github-actions
Copy link

Hi @kudpig! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

Snapshot diff report

File name Image
KaigiAppTest.checkNa
vigateToContributorS
hot_compare.png
KaigiAppTest.checkNa
vigateToStampsShot_c
ompare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
KaigiAppTest.checkNa
vigateToFloorMapShot
_compare.png
KaigiAppTest.checkNa
vigateToAboutShot_co
mpare.png

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

Test Results

36 tests   36 ✔️  2m 44s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit ecbb434.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 13:07 Inactive
@RyuNen344
Copy link
Contributor

@kudpig
could you check lint format?

@kudpig
Copy link
Contributor Author

kudpig commented Aug 15, 2023

@RyuNen344
Oops, excuse me.
I run ./gradlew spotlessKotlinApply. is it right?

@RyuNen344
Copy link
Contributor

Oops, excuse me.
I run ./gradlew spotlessKotlinApply. is it right?

Yes!! Right!!

takahirom
takahirom approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@takahirom takahirom merged commit e5caf25 into DroidKaigi:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix a bottom navigation's label from Stamps to Badges
3 participants
@kudpig @RyuNen344 @takahirom