Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bookmarksheet emptyview colors to use theme colors #532

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Update bookmarksheet emptyview colors to use theme colors #532

merged 4 commits into from
Aug 16, 2023

Conversation

okuzawats
Copy link
Contributor

@okuzawats okuzawats commented Aug 15, 2023

Issue

Overview (Required)

  • I used material theme colors in BookmarkSheet.
    • Because theme colors are not correctly defined, I have to fix the theme colors.
      • This is why the filter ui color is also fixed.
    • Because this page does not implement dark theme properly, I could not confirm to the design for dark mode. Anyway, I thought I fixed some theme colors for dark mode properly.
  • I also thought that fixing theme colors unnecessarily expand the scope of the PR, so I'd like to discard some changes to theme colors if the reviewer requested :)

Links

Screenshot

Light mode

Before After

Dark mode

Before After

@github-actions
Copy link

Hi @okuzawats! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Test Results

40 tests   40 ✔️  4m 6s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 66330ff.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 14:25 Inactive
@takahirom
Copy link
Member

Sorry, I updated the theme color please fix the conflict 🙏

@okuzawats
Copy link
Contributor Author

@takahirom
OK I resolved some conflicts.
Also, I updated the screenshots and the description.
Please check it out🙏

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 21:21 Inactive
@okuzawats
Copy link
Contributor Author

I reset some commits before my changes to theme colors, in order to avoid conflict and unnecesarry commits.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 23:25 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your input helps us create the right theme! Thanks!

@takahirom takahirom merged commit 6e8acb1 into DroidKaigi:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update BookmarkSheet EmptyView Colors to Use Theme Colors
2 participants