-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bookmarksheet emptyview colors to use theme colors #532
Update bookmarksheet emptyview colors to use theme colors #532
Conversation
Hi @okuzawats! Codes seem to be unformatted. To resolve this issue, please run |
Sorry, I updated the theme color please fix the conflict 🙏 |
@takahirom |
I reset some commits before my changes to theme colors, in order to avoid conflict and unnecesarry commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your input helps us create the right theme! Thanks!
Issue
Overview (Required)
BookmarkSheet
.Because theme colors are not correctly defined, I have to fix the theme colors.I also thought that fixing theme colors unnecessarily expand the scope of the PR, so I'd like to discard some changes to theme colors if the reviewer requested :)Links
Screenshot
Light mode
Dark mode