Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] update secondaryContainer and onSecondaryContainer #533

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

tkhs0604
Copy link
Contributor

@tkhs0604 tkhs0604 commented Aug 15, 2023

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Updated secondaryContainer and onSecondaryContainer manually with reference to Figma
  • Note: Followed by my commit, @takahirom fixed all the theme colors by exporting them from Figma 🙏

Links

Screenshot

Before After

@tkhs0604 tkhs0604 self-assigned this Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Snapshot diff report

File name Image
TimetableScreenTest.
checkGridShot_compar
e.png
TimetableItemDetailS
creenTest.checkScrol
lShot_3_compare.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkGridScrollShot_
compare.png
TimetableItemDetailS
creenTest.checkBookm
arkToggleShot_compar
e.png
TimetableScreenTest.
checkLaunchServerErr
orShot_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_4_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_2_compare.png
TimetableItemDetailS
creenTest.checkLaunc
hShot_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
AboutScreenTest.chec
kLaunchShot_compare.
png
SponsorsScreenTest.c
heckLaunchShot_compa
re.png
KaigiAppTest.checkNa
vigateToBookmarkShot
_compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Defa
ultGroup_AboutDroidK
aigiDetailPreview_1_
null_compare.png
KaigiAppTest.checkNa
vigateToContributorS
hot_compare.png
KaigiAppTest.checkNa
vigateToStampsShot_c
ompare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_D
efaultGroup_Timetabl
eListItemPreview_0_n
ull_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
KaigiAppTest.checkNa
vigateToFloorMapShot
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_D
efaultGroup_PreviewT
imetableItemDetailSu
mmary_0_null_compare
.png
KaigiAppTest.checkNa
vigateToTimetableIte
mDetailShot_compare.
png
io.github.droidkaigi
.confsched2023.about
.component_null_Defa
ultGroup_AboutDroidK
aigiDetailDarkModePr
eview_1_null_compare
.png
KaigiAppTest.checkNa
vigateToSponsorsShot
_compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Defa
ultGroup_AboutDroidK
aigiDetailDarkModePr
eview_0_null_compare
.png
KaigiAppTest.checkNa
vigateToAboutShot_co
mpare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Defa
ultGroup_AboutDroidK
aigiDetailPreview_0_
null_compare.png

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Test Results

35 tests   35 ✔️  3m 3s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit a263683.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 14:49 Inactive
@github-actions
Copy link

Hi @takahirom! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@takahirom
Copy link
Member

🙏

@takahirom takahirom merged commit fa5aee2 into main Aug 15, 2023
5 checks passed
@takahirom takahirom deleted the kenken/update_secondary_container_colors branch August 15, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants