Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Set correct app version string #534

Merged

Conversation

NakaokaRei
Copy link
Contributor

Issue

Overview (Required)

  • I implemented to show correct app version.

Links

Screenshot

Before After
image image

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Test Results

40 tests   40 ✔️  2m 42s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit ced0096.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2023 15:22 Inactive
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Almost looks good!
Please fix only one point 🙏🏼

Comment on lines 1 to 7
//
// Bundle.swift
//
//
// Created by rei.nakaoka on 2023/08/16.
//

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file header 🙏🏼
I'll add this SwiftLint rule later 🙇🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed at ced0096 !

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2023 01:27 Inactive
@ry-itto
Copy link
Member

ry-itto commented Aug 16, 2023

@NakaokaRei
Thank you for fixing! I'll merge this 🙏🏼

@ry-itto ry-itto merged commit 03d98aa into DroidKaigi:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Set correct App Version string
2 participants