Implement feature that displays results according to search input text #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chigichan24
changed the title
chigichan24
force-pushed
the
implement-search-feature
branch
from
1083c47
to
9e9edbb
Compare
|
Snapshot diff report
|
takahirom
reviewed
Aug 16, 2023
| @@ -78,4 +118,10 @@ class SearchScreenViewModel @Inject constructor( | |||
| }, | |||
| ) | |||
| } | |||
|
|
|||
| fun updateBookmark(timetableItem: TimetableItem) { | |||
There was a problem hiding this comment.
It's my preference but how about using onClickTimetableItemBookmark to promote the best practice that notifying events to ViewModel.
|
Looks good. You say this is a work in progress though. |
chigichan24
changed the title
takahirom
reviewed
Aug 17, 2023
| @@ -58,7 +61,7 @@ fun TimetableListItem( | |||
| .clickable { onClick(timetableItem) }, | |||
| ) { | |||
| Row(verticalAlignment = Alignment.CenterVertically) { | |||
| Row(modifier = Modifier.weight(1F)) { | |||
| FlowRow(modifier = Modifier.weight(1F)) { | |||
takahirom
reviewed
Aug 17, 2023
Comment on lines
48
to
49
| bookmarkedTimetableItemIds: PersistentSet<TimetableItemId>, | ||
| timetableItems: PersistentList<TimetableItem>, |
There was a problem hiding this comment.
It is a very small point. As I mentioned here we would like to have UiState for each section. 🙏
https://github.com/DroidKaigi/conference-app-2023#section
takahirom
approved these changes
Aug 17, 2023
|
Hi @chigichan24! Codes seem to be unformatted. To resolve this issue, please run |
takahirom
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
In this PR, I focused on the below implementations.
The difference of TimetableListItem
On Figma, there're no UI guides for search results. Therefore, basically, I follow to TimetableList implementation. But I updated 1. Add hour information for each session item 2. Add a day label.
I can follow to designer's or maintainer's suggestion. Please feedback on my update.🙇♂️
Out of this PR scope
BookMarkList,TimetableList, andSearchList.Links
Screenshot