Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FloorMap UI #583

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix FloorMap UI #583

merged 3 commits into from
Aug 16, 2023

Conversation

mikanIchinose
Copy link
Contributor

@mikanIchinose mikanIchinose commented Aug 16, 2023

Overview (Required)

As-is

  1. wrong floorName
    • expected: 1F
    • current: Ground
  2. wrong floorMap image
    • ground floor image named img_floormap_basement.png
    • basement floor image named img_floormap_ground.png

What I did

Screenshot

Before After

import io.github.droidkaigi.confsched2023.feature.floormap.R
import io.github.droidkaigi.confsched2023.model.FloorLevel

data class FloorMapUiState(
private val floorLevel: FloorLevel,
@DrawableRes val floorMapResId: Int,
) {
val floorName: String = floorLevel.name
val floorName: String = floorLevel.floorName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@takahirom
Copy link
Member

You are our hero 😭

wrong floorMap image
ground floor image named img_floormap_basement.png
basement floor image named img_floormap_ground.png

@mikanIchinose
Copy link
Contributor Author

No problem. It's my fault...

@github-actions
Copy link

Test Results

47 tests   47 ✔️  3m 40s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 802656e.

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2023 16:25 Inactive
@mhidaka
Copy link
Member

mhidaka commented Aug 16, 2023

@mikanIchinose Great thanks!
I'll merge to main branch your job.

@mhidaka mhidaka merged commit 80a347f into DroidKaigi:main Aug 16, 2023
5 checks passed
@mikanIchinose mikanIchinose deleted the fix-floor-map-ui branch August 16, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants