Feature/546 apply the correct icon for floormap #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinya-tan
commented
Aug 17, 2023
| @@ -84,40 +85,45 @@ fun MainScreen( | |||
| ) | |||
| } | |||
|
|
|||
| sealed class IconRepresentation { | |||
There was a problem hiding this comment.
Implement the selectedIcon of MainScreenTab to make it work with drawable.
shinya-tan
commented
Aug 17, 2023
| label = MainStrings.Timetable.asString(), | ||
| contentDescription = MainStrings.Timetable.asString(), | ||
| ), | ||
| FloorMap( | ||
| icon = Icons.Outlined.Map, | ||
| selectedIcon = Icons.Filled.Map, | ||
| selectedIcon = IconRepresentation.Drawable(drawableId = R.drawable.icon_map_fill), |
There was a problem hiding this comment.
Since Icons.Filled.Map did not align with the Figma design, I added the map_fill SVG to display.
|
Snapshot diff report
|
takahirom
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot