Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Connect API using KMP module #865

Merged
merged 4 commits into from
Aug 23, 2023
Merged

[iOS] Connect API using KMP module #865

merged 4 commits into from
Aug 23, 2023

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Aug 22, 2023

Issue

  • close #ISSUE_NUMBER

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@ry-itto ry-itto marked this pull request as ready for review August 22, 2023 18:08
@ry-itto ry-itto requested a review from a team as a code owner August 22, 2023 18:08
@ry-itto ry-itto requested a review from RyuNen344 August 22, 2023 18:08
@github-actions
Copy link

Test Results

177 tests   177 ✔️  8m 6s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 772854a.

Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@takahirom
Copy link
Member

takahirom commented Aug 23, 2023

I was wondering if you could try this. But I'll leave it to you 🙇
https://github.com/rickclephas/KMP-NativeCoroutines#swift-swift-package-manager
#862

@ry-itto
Copy link
Member Author

ry-itto commented Aug 23, 2023

I was wondering if you could try this. But I'll leave it to you 🙇 https://github.com/rickclephas/KMP-NativeCoroutines#swift-swift-package-manager #862

I think introducing KMP-NativeCoroutines is not only in iOS, so I didn't in this PR. But I'll try it!

@ry-itto ry-itto merged commit 88555a9 into main Aug 23, 2023
8 checks passed
@ry-itto ry-itto deleted the ios-connect-api branch August 23, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants