Add placeholder to SearchScreen text field and focus on when launch screen #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2024 13:44
|
As for the wording of the Placeholder, it was “Search/検索” on iOS, so I made it the same as that. |
|
"Search sessions/セッションを検索" sounds great. Could you change it? 🙏 |
OK! |
|
You can do it in this PR. But separated pull request would be better because there are different reviewers. |
|
Understood. |
|
I modified the words of placeholder.
|
takahirom
reviewed
Sep 8, 2024
| @@ -56,7 +75,32 @@ fun SearchTextFieldAppBar( | |||
| focusManager.clearFocus() | |||
| }, | |||
| ), | |||
| decorationBox = { innerTextField -> | |||
| TextFieldDefaults.DecorationBox( | |||
takahirom
approved these changes
Sep 8, 2024
|
Sorry, I forgot to write the #ISSUE_NUMBER of close in the PR. Please close the issue. |
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category App Architecture en - it should selected category App Architecture en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20App%20Architecture%20en%20-%20it%20should%20selected%20category%20App%20Architecture%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter day chip click - when click conference day 2 - it should selected day 2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20day%20chip%20click%20-%20when%20click%20conference%20day%202%20-%20it%20should%20selected%20day%202%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - it should show drop down menu]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20it%20should%20show%20drop%20down%20menu%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when device is tablet - it should no timetable items are displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20device%20is%20tablet%20-%20it%20should%20no%20timetable%20items%20are%20displayed%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category Other en - it should selected category Other en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20Other%20en%20-%20it%20should%20selected%20category%20Other%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language MIXED - it should selected language MIXED]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20MIXED%20-%20it%20should%20selected%20language%20MIXED%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - it should show drop down menu]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20it%20should%20show%20drop%20down%20menu%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language ENGLISH - it should selected language ENGLISH]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20ENGLISH%20-%20it%20should%20selected%20language%20ENGLISH%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - input search word to TextField - it should show search word and filtered items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20input%20search%20word%20to%20TextField%20-%20it%20should%20show%20search%20word%20and%20filtered%20items%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter category chip click - when click category Jetpack Compose en - it should selected category Jetpack Compose en]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20category%20chip%20click%20-%20when%20click%20category%20Jetpack%20Compose%20en%20-%20it%20should%20selected%20category%20Jetpack%20Compose%20en%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter day chip click - when click conference day 1 - it should selected day 1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20day%20chip%20click%20-%20when%20click%20conference%20day%201%20-%20it%20should%20selected%20day%201%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter day chip click - it should show drop down menu]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20day%20chip%20click%20-%20it%20should%20show%20drop%20down%20menu%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - it should no timetable items are displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20it%20should%20no%20timetable%20items%20are%20displayed%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when device is tablet - input search word to TextField - it should show search word and filtered items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20device%20is%20tablet%20-%20input%20search%20word%20to%20TextField%20-%20it%20should%20show%20search%20word%20and%20filtered%20items%5D_compare.png){kind=link}
![SearchScreenTest[SearchScreen - when server is operational - when filter language chip click - when click language JAPANESE - it should selected language JAPANESE]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-search-screen-placeholder/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/SearchScreenTest%5BSearchScreen%20-%20when%20server%20is%20operational%20-%20when%20filter%20language%20chip%20click%20-%20when%20click%20language%20JAPANESE%20-%20it%20should%20selected%20language%20JAPANESE%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
movie-before.mp4
movie-after.mp4