-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable apk distribution #152
Conversation
repository: droidkaigi/conference-app-2024 | ||
ref: gh-actions | ||
path: gh-actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some usefull workflows in another branch. These workflows were created by jmatsu and modified by tomoya0x00.
https://github.com/DroidKaigi/conference-app-2024/tree/gh-actions
I updated dependencies and switched to using Node 20.
- name: Download build outputs (APKs) | ||
uses: actions/[email protected] | ||
with: | ||
name: build-outputs | ||
path: ~/build-outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used actions/download-artifact instead of ./gh-actions/actions/get-artifact, but is there any issue?
I think it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with actions/download-artifact
. Let's try using this!
.github/workflows/drop-staging.yml
Outdated
api-token: ${{ secrets.DEPLOYGATE_API_TOKEN }} | ||
app-owner-name: droidkaigi | ||
platform: android | ||
app-id: io.github.droidkaigi.confsched2023.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think right now it's probably io.github.droidkaigi.confsched2023.dev
, but I expect it will need to be renamed to io.github.droidkaigi.confsched2024.dev
when the time comes. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the package name! So we can now use io.github.droidkaigi.confsched2024.dev
!
#154
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Fixed! 79fe1a1
.github/workflows/build.yml
Outdated
|
||
- uses: ./.github/actions/setup-java | ||
|
||
- run: ./gradlew :app-android:assemble --stacktrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For now, we don't want to spend a lot of build time because it could be costly, so how about using assembleDevDebug to specify the build variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Fixed!
b94b3be
Issue
Overview (Required)
build.yml
stage-app-push.yml
stage-app-pull-request.yml
drop-staging.yml
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)