Add SwiftUIContributorView #162
Conversation
| @@ -90,8 +90,8 @@ public struct RootReducer { | |||
| state.paths.about.append(.staff(.init())) | |||
| return .none | |||
|
|
|||
| case .about(.view(.contributersTapped)): | |||
| state.paths.about.append(.contributor(.init(text: ""))) | |||
| case .about(.view(.contributorsTapped)): | |||
| .navigationBarTitleStyle( | ||
| color: AssetColors.Surface.onSurface.swiftUIColor, | ||
| titleTextStyle: .titleMedium, | ||
| largeTitleTextStyle: .headlineSmall | ||
| ) |
There was a problem hiding this comment.
This is custom modifier.
I looked Figma design, navigation title of all screens are same style, so I changed it in RootView.
There was a problem hiding this comment.
This struct is used from TimetableDetailView, too. So moved to Model module.
|
@shin-usu Please fix conflicts 🙏 |
|
It looks like its the color names from the name update. If you change the color name to flamingo it should resolve the issue. |
shin-usu
force-pushed
the
feature/contributor_swiftui_view
branch
from
e0d5b69
to
1966f49
Compare
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
Is it possible to share these strings between iOS and Android? We should move to a shared location if that is possible.
There was a problem hiding this comment.
I don't think it was decided whether to share Resource between iOS and Android.
In fact, all iOS projects use the string catalog.
Therefore, it would be more efficient to replace all of them after the policy is decided.
Overview (Required)
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
2024-07-26.1.19.37.mov