Add tests to verify DroidKaigi2024Day and the initially displayed timetable tab #482
Conversation
| .height(64.dp), | ||
| selected = false, |
There was a problem hiding this comment.
This is what I was referencing earlier with the "hardcoded selected = false". I want to make sure that I'm not overlooking anything by changing this, so I'm highlighting it here again.
There was a problem hiding this comment.
Thanks. I think that was my mistake. 😭
| public val start: Instant, | ||
| public val end: Instant, | ||
| private val visibleForUsers: Boolean, | ||
| private val date: LocalDate, |
|
|
||
| @Test | ||
| fun `returns Day1 on September 12 2024`() { | ||
| val day1 = LocalDate(2024, 9, 12) |
There was a problem hiding this comment.
Thanks. This is just our conference domain language, but we don't say 'day1' because it could cause confusion this year. How about sep12Date or some other name?
There was a problem hiding this comment.
Understood. I think I prefer the more neutral date for all of the test cases then.
| @Test | ||
| fun `initialSelectedTabDay returns Day1 on any date except for the second conference day`() { | ||
| runTest( | ||
| expected = DroidKaigi2024Day.ConferenceDay1, |
| @@ -46,6 +48,7 @@ class TimetableScreenTest(private val testCase: DescribedBehavior<TimetableScree | |||
| captureScreenWithChecks(checks = { | |||
| checkTimetableListDisplayed() | |||
| checkTimetableListItemsDisplayed() | |||
| checkTimetableTabSelected(DroidKaigi2024Day.ConferenceDay1) | |||
There was a problem hiding this comment.
Thank you. My main concern is the potential for the app to crash on the day of the event. If we could conduct tests on 9/11 and 9/12 as well, that would be great. We might implement features such as a timeline for the timetable grid view or an "ongoing" label for the sessions, which could potentially cause issues on the event day.
There was a problem hiding this comment.
Good call! It's very easy to set up with robospec, kudos for that: be8b056
There was a problem hiding this comment.
Had to make another commit because the generated screenshot files had an unexpected intermediary folder when I added e.g. 9/12 to the output (because of the slash). 😆 I guess this is expected, but threw me off for a minute. Fixed in d4ccfa2
There was a problem hiding this comment.
I have never thought of this! 👍 This code rocks!
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-13 - it should show timetable items for ConferenceDay2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_test/timetable-default-tab-based-on-today/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-13%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay2%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-12 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_test/timetable-default-tab-based-on-today/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-12%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-11 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_test/timetable-default-tab-based-on-today/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-11%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
Introduce kotlin-test to allow for multiplatform unit tests of logic that doesn't require any UI components
The current declaration makes the day "end" at 23:59:59, but in the 999 milliseconds afterwards the behavior would've been undefined. Declare the end time explicitly with 999_999_999 nanoseconds to cover the entirety of each day
This required a change in how the tabs store their selection state (not sure why it was hardcoded at `selected = false` before...)
mannodermaus
force-pushed
the
test/timetable-default-tab-based-on-today
branch
from
577139f
to
be8b056
Compare
takahirom
added
the
awesome
Issue
Overview (Required)
Introduce
kotlin-testto allow for multiplatform unit tests of logic that doesn't require any UI componentsThe current declaration makes the day "end" at 23:59:59, but in the last second the behavior would've been undefined.
Declare the end time explicitly with 999_999_999 nanoseconds to cover the entirety of each day
This required a change in how the tabs store their selection state (not sure why it was hardcoded at
selected = falsebefore...)Links
Screenshot (Optional if screenshot test is present or unrelated to UI)