Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on TimetableGridItem.kt #491

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

hiraike32
Copy link
Contributor

Issue

  • nothing

Overview (Required)

Links

  • nothing

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 15, 2024 13:29 Inactive
@@ -162,7 +163,7 @@ fun TimetableGridItem(
) {
Icon(
modifier = Modifier.height(TimetableGridItemSizes.scheduleHeight),
imageVector = timetableItem.room.icon,
imageVector = vectorResource(checkNotNull(timetableItem.room.icon)),
Copy link
Contributor Author

@hiraike32 hiraike32 Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build error occurred because #470 made TimetableRoom.icon as DrawableResource? type, and #475 newly referenced TimetableRoom.icon.
Therefore, I modified TimetableRoom.icon could be received as a DrawableResource? type here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😭 This is exactly what we needed!

@hiraike32 hiraike32 changed the title Fix build error Fix build error on TimetableGridItem.kt Aug 15, 2024
@takahirom takahirom merged commit a3f6b55 into DroidKaigi:main Aug 15, 2024
7 of 8 checks passed
@hiraike32 hiraike32 deleted the fix/build-error branch August 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants