[iOS] Modify header tab on ContributorView #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-usu
force-pushed
the
feature/ios_compose_view_contributor_tapped
branch
from
8296c6e
to
a0a4731
Compare
shin-usu
force-pushed
the
feature/ios_contributor_view_header_tab
branch
from
e12c023
to
3e6057c
Compare
shin-usu
commented
Aug 20, 2024
|
|
||
| switch viewType { | ||
| switch selectedTab { |
There was a problem hiding this comment.
I wanted to replace this to TabView, but only KmpContributorComposeViewControllerWrapper screen is white out in TabView...
shin-usu
commented
Aug 20, 2024
Comment on lines
-48
to
-51
| .sheet(item: $showingUrl, content: { url in | ||
| SafariView(url: url.id) | ||
| .ignoresSafeArea() | ||
| }) |
There was a problem hiding this comment.
ContributorView and KmpPresenterContributorView both have a sheet modifier and there was a bug that sheet is closed as soon as it is open.
Therefore, I remove it.
shin-usu
commented
Aug 20, 2024
| @@ -1,5 +1,5 @@ | |||
| import SwiftUI | |||
| @preconcurrency import shared | |||
Base automatically changed from
feature/ios_compose_view_contributor_tapped
to
main
August 21, 2024 01:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Modified header tab on ContributorView because slider text is missing
Links
Movie (Optional)
2024-08-21.2.02.38.mov