Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Search Feature: Remove filter of Workshop Day #571

Conversation

hicka04
Copy link
Contributor

@hicka04 hicka04 commented Aug 17, 2024

Issue

Overview (Required)

  • Remove workshop day from search filter options
    • Add options to Selectable protocol
      • Default value is allCases
    • Override options in DroidKaigi2024Day
  • It is possible to overwrite allCases , but I thought allCases should list all cases, so I created Options.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@hicka04
Copy link
Contributor Author

hicka04 commented Aug 17, 2024

It seems like we can solve #441 in a similar way.

Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commit!
LGTM👍

@MrSmart00 MrSmart00 merged commit e70bd92 into DroidKaigi:main Aug 17, 2024
4 checks passed
@hicka04 hicka04 deleted the ios-remove-workshop-day-from-search-filter-options branch August 18, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Search Feature: Remove filter of Workshop Day
2 participants