-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Create a cache system for images #573
[iOS] Create a cache system for images #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mltokky
Thank you for your commit! Great!!
SpeakerIcon component could be applied to other screens.
If you have time, could you please apply it to the following screens as well?
- TimetableDetailView
- ContributorListItemView
- StaffView
Of course, you can refuse.
This commitment is enough to resolve the issue.
@shin-usu Yes, I'll apply it! |
@shin-usu |
@shin-usu Notes
|
Thank you very much😊 About crashes, this bug is known issue. It is sufficient to check only SwiftUI view on ContributorView👍 |
import Foundation | ||
import SwiftUI | ||
|
||
private actor SpeakerIconInMemoryCache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be appropriate to rename this actor as well as circular icon view.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry...
I forgot rename this actor.
I fixed it.
Please check again 🙏🏻
…ache` Because related view is renamed, so I changed it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉 Thank you for your commitment to my additional request!
Issue
Overview (Required)
URLSession
may returns data from cache after second time, so speaker icon is displayed faster than before.Movie (Optional)
launch at first time
430_before.mp4
430_after.mp4
launch at second time
430_2_after.mp4