♻️ Connecting Compose ProfileCardScreen as an iOS app screen #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it in the Shared file.
…o convert it to UIImage has been added. This method has to be integrated later, since the exact same file exists in other modules.
Corvus400
changed the title
|
Detekt check failed. Please run |
Corvus400
commented
Aug 27, 2024
Comment on lines
+1
to
+35
| package io.github.droidkaigi.confsched.profilecard | ||
|
|
||
| import androidx.compose.ui.graphics.ImageBitmap | ||
| import kotlinx.cinterop.ExperimentalForeignApi | ||
| import kotlinx.cinterop.refTo | ||
| import platform.CoreGraphics.CGBitmapContextCreate | ||
| import platform.CoreGraphics.CGBitmapContextCreateImage | ||
| import platform.CoreGraphics.CGColorSpaceCreateWithName | ||
| import platform.CoreGraphics.CGImageAlphaInfo | ||
| import platform.CoreGraphics.kCGBitmapByteOrder32Little | ||
| import platform.CoreGraphics.kCGColorSpaceSRGB | ||
| import platform.UIKit.UIImage | ||
|
|
||
| // TODO Integrate with app-ios-shared methods. | ||
| @OptIn(ExperimentalForeignApi::class) | ||
| internal fun ImageBitmap.toUiImage(): UIImage { | ||
| val buffer = IntArray(width * height) | ||
| readPixels(buffer) | ||
|
|
||
| // https://github.com/takahirom/roborazzi/blob/main/roborazzi-compose-ios/src/iosMain/kotlin/io/github/takahirom/roborazzi/RoborazziIos.kt#L88C51-L88C68 | ||
| val colorSpace = CGColorSpaceCreateWithName(kCGColorSpaceSRGB) | ||
| val bitmapInfo = CGImageAlphaInfo.kCGImageAlphaPremultipliedFirst.value or kCGBitmapByteOrder32Little | ||
| val context = CGBitmapContextCreate( | ||
| data = buffer.refTo(0), | ||
| width = width.toULong(), | ||
| height = height.toULong(), | ||
| bitsPerComponent = 8u, | ||
| bytesPerRow = (4 * width).toULong(), | ||
| space = colorSpace, | ||
| bitmapInfo = bitmapInfo, | ||
| ) | ||
|
|
||
| val cgImage = CGBitmapContextCreateImage(context) | ||
| return cgImage?.let { UIImage.imageWithCGImage(it) } ?: UIImage() | ||
| } |
There was a problem hiding this comment.
The exact same implementation is available in another module.
However, I was not sure where to put this process, so I copied it and put it as is.
Which module should I put it in? 🤔
There was a problem hiding this comment.
How about putting this to core/ui?👀
There was a problem hiding this comment.
We can have another pull request for this👀
Corvus400
commented
Aug 27, 2024
Comment on lines
+192
to
+194
| KmpProfileCardComposeViewControllerWrapper { text, image in | ||
| // TODO Implement a sharing function. | ||
| } |
There was a problem hiding this comment.
The goal is to have the Compose editing screen appear when the profile card icon in the bottom navigation bar is tapped in the iOS app.
Since the goal of this task is the above, the share function is not part of this PR.
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Movie (Optional)
before.mov