-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ContributorsScreen] Display the total number of persons in ContributorsScreen #982
Merged
takahirom
merged 7 commits into
DroidKaigi:main
from
raseln:raseln/implement_contributors_count_ui
Sep 7, 2024
Merged
[ContributorsScreen] Display the total number of persons in ContributorsScreen #982
takahirom
merged 7 commits into
DroidKaigi:main
from
raseln:raseln/implement_contributors_count_ui
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app-ios/Sources/ContributorFeature/KmpPresenterContributorView.swift
takahirom
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on iOS as well; it seems great.
shin-usu
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS implementation looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
ContributorsScreen
of ComposeContributorsScreen
of SwiftUI for both representationLinks
Movie (Optional)
BeforeAndroid.mp4
AfterAndroid.mp4
BeforeiOS.mov
AfteriOS.mov