Navigation Drawer color fix for text and icons - Android 8.0 (API level 26) #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preet90
changed the title
|
I think for the change to go in 'unavailable' should default to the older 'paper plane' arrow. And thinking about it, I like the 'paper plain' arrow. Can the change be done so it's optional for the new vehicle specific icons vs the old style? Thx |
preet90
force-pushed
the
nav_drawer_color
branch
from
cbb1754 to
f0f9397
Compare
…n drawer which caused the issue with the color of the text and icons in Android 8. Added the default color for text and icons.
|
This PR is for the issue, with the wrong icons and text color in nav drawer (#1871) I have removed the other commit (vehicle specific icons) from this PR. |
billbonney
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue --> #1871
No color has been defined for the text and the icons in the navigation drawer which caused the issue with the color of the text and icons in Android 8. So, added the default color for text and icons.