Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

35 support all image resolutions #46

Merged
merged 4 commits into from
Jan 27, 2025
Merged

35 support all image resolutions #46

merged 4 commits into from
Jan 27, 2025

Conversation

cwmeijer
Copy link
Contributor

@cwmeijer cwmeijer commented Jan 15, 2025 •
edited
Loading

  1. Added padding to make width and height divisible by 16.
  2. Added tests.
  3. Added docstrings.
  4. Refactored extract_flair_features, splitting it into multiple methods
  5. Updated some logger calls as I noticed I needed more info while debugging

Can be tested by

  • running the tests (pytest in root for example)
  • running python .\src\segmentmytif\main.py --input .\tests\test_data\test_image.tif -l .\tests\test_data\test_image_labels.tif -p .\tests\test_data\test_image_out_flair_scale1.tif --feature_type=FLAIR

@cwmeijer cwmeijer marked this pull request as ready for review January 20, 2025 09:46
rogerkuou
rogerkuou approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@rogerkuou rogerkuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cwmeijer, nice one! I only have one super minor comment. Please feel free to merge!

rogerkuou
rogerkuou reviewed Jan 20, 2025
View reviewed changes
@cwmeijer cwmeijer merged commit d9d3c8c into main Jan 27, 2025
11 checks passed
@cwmeijer cwmeijer deleted the 35-support-all-resolutions branch January 27, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerkuou rogerkuou rogerkuou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwmeijer @rogerkuou