Development for v6.0.4 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `dbW_weatherData_round()` now rounds both "weatherList" and "weather data frame" objects; argument "digits" can now also be logical (if TRUE, then digits takes the default value of 4) or not finite (e.g., NA; not finite values return the input without rounding). - argument "round" of `dbW_dataframe_to_weatherData()` is deprecated and changed the default value from rounding to 2 digits to no rounding (NA) - recommended replacement is a separate call to `dbW_weatherData_round()`. - argument "digits" of `dbW_generateWeather()` changed the default value from rounding to 4 digits to no rounding (NA)
- `dbW_generateWeather()` gained `"return_weatherDF"` and now returns a user requested weather object type. If `return_weatherDF` is `TRUE`, then the result is converted to a data frame where columns represent weather variables; otherwise, a list of elements of class `swWeatherData` is returned (as previously).
- `dbW_imputeWeather()` combines the use of the weather generator and `rSW2utils::impute_df()` for replacing missing weather values - `dbW_imputeWeather()` simplifies the weather section of the demo vignette substantially
`dbW_substituteWeather()` replaces missing weather values in one weather data object with values from a second weather data object
…of approaches Approaches are linear interpolation for short missing spells, possibly fixed values for short missing precipitation spells, substitution from a second weather data object, and finally replacement with long term daily mean values
New family of functions `sw_meteo_obtain` that obtain (download) weather data from external sources and prepare for use by `"rSOILWAT2"` * `sw_meteo_obtain_DayMet()` obtains and formats data from `"Daymet"` * `sw_meteo_obtain_SCAN()` obtains and formats data from `"SCAN"` - vignette "demo" is simplified thanks to `sw_meteo_obtain_DayMet()`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 58.99% 58.93% -0.07%
==========================================
Files 42 43 +1
Lines 8263 8593 +330
==========================================
+ Hits 4875 5064 +189
- Misses 3388 3529 +141 ☔ View full report in Codecov by Sentry. |
- functionality to impute and 'fix' weather - functionality to download weather and format for rSOILWAT2
- [scalar_in_linter] Use == to match length-1 scalars, not %in%. Note that == preserves NA where %in% does not. - [if_not_else_linter] In a simple if/else statement, prefer `if (A) x else y` to the less-readable `if (!A) y else x`. - [keyword_quote_linter] Only quote named arguments to functions if necessary, i.e., if the name is not a valid R symbol (see ?make.names) - [unreachable_code_linter] Code inside a conditional loop with a deterministically false condition should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.