Use issuer as aud in private_key_jwt #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conforms to FAPI 2.0 recommendations and is consistent with proposed changes to RFC 7523
Hopefully fixes build...
Since some of them share some code, I just went ahead and updated all of them to use the latest versions of our libraries.
- Delete cookie on logout - Title samples correctly - Fix some vscode config files
|
"This tale grew in the telling" I updated the private_key_jwt samples to use the issuer identifier as the audience, and while I was there I fixed some package updates so that we wouldn't have warnings. Some of the code in the basics folder is shared, so it spilled into a few other samples, and I ended up updating the package references for all samples in the Basics subdir. As I was testing them, I ran into some silly things like UI labels and the logout button not being quite right, so I fixed that as well. |
maartenba
approved these changes
Jan 30, 2025
|
|
khalidabuhakmeh
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conforms to FAPI 2.0 recommendations and is consistent with proposed changes to RFC 7523