generated from MaximTiberiu/oop-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone1 - User authentication + database #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both classes are singletons and should be instantiated on startup. The EnvironmentReader deals with the .env file and retrieves the connection string ( as it should not be plainly available in code ) and the Database class creates the app-wide connection string.
…eals with initializing all the database tables if they haven't already been created. Implemented a wrapper so the environment setting and getting is not os-specific
…ses -1 instead of NULL.
… + finished implementing login logic.
- Implemented a logger that records significant actions within the application - Includes timestamped entries for better debugging and monitoring - Logs are saved in a dedicated "Logs" directory
…rom the cmakelist + some small warning removing.
Moved all application files to the src directory and created a new directory for unittests. Each has a separate makefile.
05f7b16
to
1b40a90
Compare
1b40a90
to
80a70c7
Compare
e039e02
to
60ed223
Compare
8f920c4
to
d76bb23
Compare
d76bb23
to
354caa7
Compare
Trying to use ctest to run the unit tests
57e0959
to
21e0ee7
Compare
MaximTiberiu
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved.
e962cb7
to
d55bc42
Compare
d55bc42
to
6952483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Implement Database Connections, User Authentication, and Logging
Description
Database Connections and Authentication:
Implemented the core logic for connecting to the database and handling user authentication.
Added integration tests for login functionality to verify database interactions and authentication logic.
Logger Class:
Created a logger class to manage application logs, with each app session generating a new log file.
The logger captures various information to aid in debugging and monitoring.
Testing:
Added unit tests for the password hashing function to ensure security and functionality.
Created integration tests for login logic to validate the end-to-end authentication process.
Rationale
These changes establish the foundational components of database connectivity, user authentication, and logging. The unit and integration tests enhance code reliability and maintainability by ensuring critical functions are working as expected.