Replace isLoading with shouldShowSkeleton in shouldShowNotFoundPage

DylanDylann · Mar 25, 2024 · 6873f24 · 6873f24
1 parent e55b82d
commit 6873f24
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/pages/home/ReportScreen.tsx b/src/pages/home/ReportScreen.tsx
@@ -341,7 +341,7 @@ function ReportScreen({
     // eslint-disable-next-line rulesdir/no-negated-variables
     const shouldShowNotFoundPage = useMemo(
         (): boolean =>
-            !isLoading &&
+            !shouldShowSkeleton &&
             ((!wasReportAccessibleRef.current &&
                 !firstRenderRef.current &&
                 !report.reportID &&
@@ -350,7 +350,7 @@ function ReportScreen({
                 !userLeavingStatus) ||
                 shouldHideReport ||
                 (!!reportIDFromRoute && !ReportUtils.isValidReportIDFromPath(reportIDFromRoute))),
-        [report, reportMetadata, isLoading, shouldHideReport, isOptimisticDelete, userLeavingStatus, reportIDFromRoute],
+        [shouldShowSkeleton, report.reportID, isOptimisticDelete, reportMetadata?.isLoadingInitialReportActions, userLeavingStatus, shouldHideReport, reportIDFromRoute],
     );
 
     const fetchReport = useCallback(() => {