fix: remaining issues

DylanDylann · Jun 12, 2024 · e115cdc · e115cdc
1 parent 03f243d
commit e115cdc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/libs/OptionsListUtils.ts b/src/libs/OptionsListUtils.ts
@@ -529,8 +529,8 @@ function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<
 
         return Object.assign(prevReportActionErrors, action.errors);
     }, {});
-    const parentReportAction: OnyxEntry<ReportAction> | null =
-        !report?.parentReportID || !report?.parentReportActionID ? null : allReportActions?.[report.parentReportID ?? '']?.[report.parentReportActionID ?? ''] ?? null;
+    const parentReportAction: OnyxEntry<ReportAction> =
+        !report?.parentReportID || !report?.parentReportActionID ? undefined : allReportActions?.[report.parentReportID ?? '']?.[report.parentReportActionID ?? ''];
 
     if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {
         const transactionID = parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? parentReportAction?.originalMessage?.IOUTransactionID : null;

diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts
@@ -61,15 +61,15 @@ Onyx.connect({
     },
 });
 
-let myPersonalDetails: OnyxEntry<OnyxPersonalDetails> | EmptyObject | null = {};
+let myPersonalDetails: OnyxEntry<OnyxPersonalDetails> | EmptyObject = {};
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => {
         if (!value || currentUserAccountID === -1) {
             return;
         }
 
-        myPersonalDetails = value[currentUserAccountID];
+        myPersonalDetails = value[currentUserAccountID] ?? {};
     },
 });