Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7080 Updating IronPython2.7 package Description #13

Conversation

RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Jun 18, 2024

Purpose

Updating Description for IronPython2.7 package.
I was not able to test if the description was updated due that Dynamo is getting the data from the server, then first need to be published and then we will be able to test.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Updating Description for IronPython2.7 package.

Reviewers

@QilongTang
@mjkkirschner
@pinzart90
@jasonstratton

FYIs

@reddyashish

Updating Description for IronPython2.7 package.
@QilongTang
Copy link
Contributor

Requesting review from Turbo team

@RobertGlobant20
Copy link
Contributor Author

@AlexisErazoGlobant could you review this changes?
Thanks

Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this took so long. Do we need to update the package version?

@QilongTang
Copy link
Contributor

Sorry that this took so long. Do we need to update the package version?

I think so, otherwise the package cant be re-published

Bumping package version
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sm6srw
Copy link
Contributor

sm6srw commented Jul 2, 2024

Please note that a package with signed binaries will be available in Jenkins here after merge (and sync).

@QilongTang QilongTang merged commit 85c8308 into DynamoDS:master Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants