Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to use shared scripts for build and remove docker use #93

Merged
merged 12 commits into from
Feb 23, 2024

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Feb 21, 2024

Purpose

  • Remove docker use
  • For most steps use shared scripts
  • publish still relies on a custom script as I'd like to leverage the packaging happening during the build, making a nuspec unnecessary.

I somehow need to test this without merging this PR - I guess I will send another temp PR to the mirror?

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an improvement for later but I feel we can also move this script to the common CICDResources repo as it seems to be common to projects using the repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I am not sure how we'd do that - this is the script that retrieves the common cicd resources... perhaps we could add something to the CI lib directly?

pipeline.yml Outdated Show resolved Hide resolved
pipeline.yml Outdated Show resolved Hide resolved
@mjkkirschner
Copy link
Member Author

successful build, scan and test on the internal PR here:
https://git.autodesk.com/Dynamo/PackageManagerClient/pull/6
I will merge this and watch the mirror for successful push to nuget - will send another PR if that fails.

@mjkkirschner mjkkirschner merged commit ae9bb2a into DynamoDS:master Feb 23, 2024
10 checks passed
@mjkkirschner mjkkirschner deleted the nodocker branch February 23, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants