-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to use shared scripts for build and remove docker use #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an improvement for later but I feel we can also move this script to the common CICDResources repo as it seems to be common to projects using the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I am not sure how we'd do that - this is the script that retrieves the common cicd resources... perhaps we could add something to the CI lib directly?
successful build, scan and test on the internal PR here: |
Purpose
I somehow need to test this without merging this PR - I guess I will send another temp PR to the mirror?
Declarations
Check these if you believe they are true
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of