Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 workflow validation in case multiple srg exist in a single workflow #66

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

drqc
Copy link
Collaborator

@drqc drqc commented Nov 15, 2023

Feature multiple workflows/multiple srg per workflows summarized in a single execution. Still a work in progress.

Pending items:

  • unit test
  • integration test
  • documentation updates
  • test with different use cases
  • Check wait times against dynatrace platform standards

@drqc drqc requested a review from eemrdog November 15, 2023 05:12
@drqc drqc linked an issue Nov 15, 2023 that may be closed by this pull request
@@ -68,9 +69,16 @@ class SRGCommandEvaluate implements BaseCommand {
.default("90")
.env("SRG_EVALUATION_DELAY");

const multipleSRG = new Option(
"--multiple-guardians [multipleGuardians]",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither "--multiple-guardians" nor "SRG_MULTIPLE_GUARDIANS=true" works for multiple SRG evaluation

Copy link

@eemrdog eemrdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good! documentation can be separated for the sake of merging the "version" related improvements on the main branch to be able to test them together.

@drqc drqc force-pushed the 41-workflow-validation-in-case-multiple-srg-exist-in-a-single-workflow branch from 07ff096 to 1369928 Compare November 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow validation in case multiple SRG exist in a single workflow
2 participants