Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a default deserialisation to adaptive_formats #34

Merged
merged 1 commit into from
May 24, 2021

Conversation

fabi321
Copy link
Contributor

@fabi321 fabi321 commented May 24, 2021

No description provided.

@fabi321
Copy link
Contributor Author

fabi321 commented May 24, 2021

How should we handle this? Error due to update of rust nightly. It compiled on my machine even after updating my nightly version.

@DzenanJupic
Copy link
Owner

@fabi321 thank you for the PR!

How should we handle this? Error due to update of rust nightly. It compiled on my machine even after updating my nightly version.

I actually ran into a similar problem and thought it was a bug.

For us there are two options:

  1. Just use the new proposed way of .ok_or(Error::NoStreams) (playground)
  2. Make our own Result type (playground)

Since the own Result type leads to a bunch of weird situations, I guess, as sad as it might be, we have to go with option one, and replace each opt? with opt.ok_or(Error::NoStreams).

@DzenanJupic DzenanJupic merged commit ec0af3f into DzenanJupic:master May 24, 2021
@fabi321 fabi321 deleted the adaptive_formats_default branch May 25, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants