Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SORRMv3 ice runoff mapping #6759

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

darincomeau
Copy link
Member

Changes the ice runoff mapping file (ROF2OCN_ICE_RMAPNAME) for the SOwISC12to30E3r3 ocean mesh to version with increased smoothing.

New mapping file has been staged in public inputdata repo, world readable.

[BFB] except
[non-BFB] for cases with the SOwISC12to30E3r3 ocean mesh (not in current testing).

@darincomeau
Copy link
Member Author

@@ -5660,7 +5660,7 @@
</gridmap>

<gridmap ocn_grid="SOwISC12to30E3r3" rof_grid="r05">
<map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_r05_to_SOwISC12to30E3r3_cstmnn.r150e300.20240808.nc</map>
<map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_r05_to_SOwISC12to30E3r3_Ratio0.5_maxFlux0.001.Greenland100x+Antarctica100x.nc</map>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have the right naming convention. Also make sure its not in netCDF4 format.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rljacob what netcdf format should it be? using ncks, it seems the possible choices are:

-5, --5, 64bit_data Output file in netCDF3 64-bit data (aka CDF5, PnetCDF) storage format
-6, --6, 64, 64bit_offset Output file in netCDF3 64-bit offset storage format

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rljacob do you have a suggestion for the file name? this is a new kind of smoothing that has many different possible parameter settings which I feel should be reflected in the filename. do we just need to put 'cstmnn' before all of the other stuff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-5, --5, 64bit_data. how about map_r05_to_SOwISC12to30E3r3_Ratio0.5_maxFlux0.001.Greenland100x+Antarctica100x.cstmnn.20241120.nc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or map_r05_to_SOwISC12to30E3r3_rat0.5_maxFlx0.001.Grlnd100x+Ant100x.cstmnn.20241120.nc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want the algorithm and datestring on the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove the "+" sign. those can lead to trouble in strings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed name to map_r05_to_SOwISC12to30E3r3_rat0.5_maxFlx0.001.Grlnd100x_Ant100x.cstmnn.20241120.nc.
Output of ncdump -k is 64-bit offset.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of successful testing of this map in this configuration. Thanks, @darincomeau!

@jonbob
Copy link
Contributor

jonbob commented Nov 26, 2024

The HR runoff map created with the same process is named

map_r05_to_RRSwISC6to18E3r5_cstmnn.r250e1250_58NS.20240328.nc

I would prefer to stick to that naming convention, if no one has any issues with it. @darincomeau and @rljacob ?

@rljacob
Copy link
Member

rljacob commented Nov 26, 2024

Just flip where "cstmnn" is in the string: map_r05_to_RRSwISC6to18E3r5_r250e1250_58NS.cstmnn.20240328.nc

@darincomeau
Copy link
Member Author

Changed file name to map_r05_to_SOwISC12to30E3r3_r250e1250_58NS.cstmnn.20241120.nc. Previous file name still exists as I have a current run going using that file name, will delete once that run stops.

jonbob added a commit that referenced this pull request Dec 3, 2024
…6759)

Change SORRMv3 ice runoff mapping

Changes the ice runoff mapping file (ROF2OCN_ICE_RMAPNAME) for the
SOwISC12to30E3r3 ocean mesh to version with increased smoothing.

New mapping file has been staged in public inputdata repo, world
readable.

[BFB] for all currently tested configurations
@jonbob
Copy link
Contributor

jonbob commented Dec 3, 2024

Passes:

  • SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod

verified new file is on the inputdata repo

merged to next

@jonbob jonbob merged commit 344b425 into E3SM-Project:master Dec 4, 2024
9 checks passed
@jonbob
Copy link
Contributor

jonbob commented Dec 4, 2024

merged to master

jonbob added a commit that referenced this pull request Dec 23, 2024
…6794)

Change range of solid ice runoff removal from 60S to 57S

Extends the northern range of solid ice runoff from Antarctica from 60S
to 57S when the ocean's namelist option
config_remove_ais_ice_runoff = .true.. The new solid ice runoff mapping
with increased smoothing for the SOwISC12to30E3r3 mesh in PR #6759 has a
small amount of runoff north of 60S, which needs to be removed when
Antarctic solid ice runoff is intended to be removed.

[BFB] for all tested configuration
jonbob added a commit that referenced this pull request Dec 24, 2024
Change range of solid ice runoff removal from 60S to 57S

Extends the northern range of solid ice runoff from Antarctica from 60S
to 57S when the ocean's namelist option
config_remove_ais_ice_runoff = .true.. The new solid ice runoff mapping
with increased smoothing for the SOwISC12to30E3r3 mesh in PR #6759 has a
small amount of runoff north of 60S, which needs to be removed when
Antarctic solid ice runoff is intended to be removed.

[BFB] for all tested configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants