Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for reading elevation profile #7048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donghuix
Copy link
Contributor

@donghuix donghuix commented Feb 21, 2025

Fixes reading of elevation profile.

Fixes #7039
[BFB]

@bishtgautam bishtgautam self-assigned this Feb 21, 2025
@bishtgautam
Copy link
Contributor

@hydrotian, Does this bug impact the default model or any existing tests?

@bishtgautam bishtgautam added bug fix PR MOSART MOSART river model labels Feb 21, 2025
@donghuix
Copy link
Contributor Author

@hydrotian, Does this bug impact the default model or any existing tests?

This bug does not affect tests when inundation is turned off.

We have added three tests that turn on MOSART inundation: unstructure, rof_ocn_2way, and rof_lnd_2way.
unstructure and rof_ocn_2way use MOSART input file that has ele, thus the bug does not affect those two tests. For rof_lnd_2way, it uses a MOSART input file that does not contain an elevation profile, so hypothetical values are used. So, this bug fix does not affect those three tests with inundation turned on.

@hydrotian Let me know if I missed any tests for MOSART inundation.

@hydrotian
Copy link
Contributor

so hypothetical values are used. So, this bug fix does not affect those three tests with inundation turned on.

That makes sense. In the future maybe we should only use ele instead of ele0, ele1 ... It looks good to me now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR MOSART MOSART river model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug for reading elevation profile for inundation simulation in MOSART
3 participants