Avoid calling METIS for cell partitioning with one task #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwjones
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
This looks fine, thanks @mwarusz . Approving based on code inspection and unit tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging and performance testing it is sometimes useful to be able to run with just one MPI task. Right now attempting to do that on some machines (e.g. Frontier) results in a floating point exception inside METIS
PartGraphKway. This seems to be a known issue: KarypisLab/METIS#67.This PR makes cell partitioning with a single task a special-case and simply directly assigns every cell to the one task.
Checklist