Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prescribe an invariant solar constant #3112

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

bogensch
Copy link
Contributor

Adds option for prescribing an invariant solar constant (i.e. total solar irradiance at TOA). Used for idealized experiments such as Radiative Convective Equilibrium (RCE), which is a supported DPxx case. Sets a default value for the DPxx RCE case, which conforms to the value used in RCEMIP.

DIFFs are expected for ERS_P16_Ln22.ne30_ne30.FRCE-SCREAMv1-DP (the DPxx RCE test case), but should be BFB for all other tests.

@bogensch bogensch added BFB Bit for bit radiation regarding the radiation scheme DP-SCREAM CI: automerge WARNING: Still in an experimental phase labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce checks passing

Wonderful, this rule succeeded.

Make sure that checks are not failing on the PR, and reviewers approved

  • #approved-reviews-by >= 1
  • #changes-requested-reviews-by == 0
  • any of:
    • all of:
      • check-success="gcc-openmp / dbg"
      • check-success="gcc-openmp / fpe"
      • check-success="gcc-openmp / opt"
      • check-success="gcc-openmp / sp"
    • check-skipped={% raw %}gcc-openmp / ${{ matrix.build_type }}{% endraw %}
  • any of:
    • all of:
      • check-success="gcc-cuda / dbg"
      • check-success="gcc-cuda / opt"
      • check-success="gcc-cuda / sp"
    • check-skipped={% raw %}gcc-cuda / ${{ matrix.build_type }}{% endraw %}
  • any of:
    • all of:
      • check-success="cpu-gcc / ERS_Ln22.ne4pg2_ne4pg2.F2010-SCREAMv1.scream-small_kernels--scream-output-preset-5"
      • check-success="cpu-gcc / ERS_Ln9.ne4_ne4.F2000-SCREAMv1-AQP1.scream-output-preset-2"
      • check-success="cpu-gcc / ERS_P16_Ln22.ne30pg2_ne30pg2.FIOP-SCREAMv1-DP.scream-dpxx-arm97"
      • check-success="cpu-gcc / SMS_D_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.scream-mam4xx-all_mam4xx_procs"
    • check-skipped={% raw %}cpu-gcc / ${{ matrix.test.short_name }}{% endraw %}
  • any of:
    • check-skipped=cpu-gcc
    • check-success=cpu-gcc

Copy link

github-actions bot commented Nov 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/scream/pr-preview/pr-3112/
on branch gh-pages at 2024-11-19 21:23 UTC

Copy link
Contributor

@whannah1 whannah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mergify mergify bot merged commit 69a3d39 into master Nov 20, 2024
21 checks passed
@mergify mergify bot deleted the bogensch/add_fixed_solar_constant branch November 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB Bit for bit CI: automerge WARNING: Still in an experimental phase DP-SCREAM radiation regarding the radiation scheme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants