Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #3

Merged
merged 10 commits into from
Sep 25, 2024
Merged

API cleanup #3

merged 10 commits into from
Sep 25, 2024

Conversation

EAGrahamJr
Copy link
Owner

  • Removed unused internal messaging
  • Cleaned up HomeAssistant lighting commands for effects-types
  • Tweaked/cleaned up Movements for more consistency and removed "arbitrary" limit checks
  • New "animation" for graphics to show an 8-ball and the classic 8-ball fortunes

Has all certified fortunes and will dipslay a fortune in the specified `Graphics` context. The font-size is scaled to fit a single line (TODO better/manual splits).

Also will display an 8-ball image.
Actions already have stop-checks built into them, so that's where things _can_ be applied. Another option is to simply sub-class and over-ride any of the movement execution functions and add in additional logic, if necessary (e.g. limit switches).
Latch will work better than `while/sleep` and the limit test was not useful.
* Everything now has a notion of "where" it is
* Stepper rotator handles ranges a bit better
* Little bit of help for actions and timing
@EAGrahamJr EAGrahamJr merged commit 4a54622 into main Sep 25, 2024
1 of 2 checks passed
@EAGrahamJr EAGrahamJr deleted the api-cleanup branch January 5, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant