Add peso symbol to constants #34
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 70.54% 70.54%
=======================================
Files 12 12
Lines 275 275
=======================================
Hits 194 194
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
| @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
|
|
|||
| ## [0.0.6] - 2024-12-06 11:00:00 | |||
There was a problem hiding this comment.
@jdebacker. Update this to 0.0.7.
.github/workflows/build_and_test.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| python-version: ["3.10", "3.11"] | |||
| python-version: ["3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
@jdebacker. This line should change to be just "3.11", "3.12".
.github/workflows/build_and_test.yml
Outdated
| auto-update-conda: true | ||
| activate-environment: ogphl-dev | ||
| activate-environment: ogcore-dev |
There was a problem hiding this comment.
@jdebacker. This line should be ogphl-dev
| @@ -163,6 +163,6 @@ situations, in which case other contributors are here to help. | |||
| (Sec_ContribFootnotes)= | |||
| ## Footnotes | |||
|
|
|||
| [^recent_python]:The most recent version of Python from Anaconda is Python 3.12. `OG-PHL` is currently tested to run on Python 3.10 and 3.11. | |||
| [^recent_python]:The most recent version of Python from Anaconda is Python 3.12. `OG-PHL` is currently tested to run on Python 3.10, 3.11, and 3.12. | |||
There was a problem hiding this comment.
@jdebacker. We should remove 3.10 from this line.
|
@jdebacker. One other update is to change line 14 of |
|
@rickecon Thanks for the thorough review. I've updated the changes to incorporate your suggestions. |
|
@jdebacker. Thanks for this PR. Looks great. Merging now. |
This PR updates
constants.pyto include the ₱ symbol.