Bugfix Publication pub type max length #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mberacochea
force-pushed
the
bugfix/europepmc-api-fields-lenlimit
branch
from
73894c1 to
3ee7e1d
Compare
mberacochea
commented
Nov 7, 2023
I've increased the max len of the pub_type in the Publication model. To prevent the import to fail in the future I've implemented a brute truncation mechanism when a Publication is saved.
mberacochea
force-pushed
the
bugfix/europepmc-api-fields-lenlimit
branch
from
e3757c5 to
c3dc316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate the fields in the Publication model if longer than expected.
I've increased the max len of the pub_type in the Publication model.
To prevent the import to fail in the future I've implemented a brute
truncation mechanism when a Publication is saved.